Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11694 )
Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag ...................................................................... Patch Set 2: Code-Review+2 (1 comment) My only concern is the commit message, otherwise I am ok with the change. http://gerrit.cloudera.org:8080/#/c/11694/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11694/2//COMMIT_MSG@8 PS2, Line 8: Can you mention somehow that the original was reverted, and this commits adds a specific fix? -- To view, visit http://gerrit.cloudera.org:8080/11694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4a9098a2085a385351477c715ae245d83bf1c72 Gerrit-Change-Number: 11694 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 16 Oct 2018 12:20:30 +0000 Gerrit-HasComments: Yes
