Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11694 )
Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11694/3/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/11694/3/be/src/exec/hdfs-parquet-table-writer.cc@168 PS3, Line 168: num_values_ = 0; > move below pages_.clear()? Done http://gerrit.cloudera.org:8080/#/c/11694/3/be/src/exec/hdfs-parquet-table-writer.cc@311 PS3, Line 311: // Size of newly created pages. Defaults to DEFAULT_DATA_PAGE_SIZE and is increased > Maybe add a brief comment here? While you're here, maybe move pages_ below Moved pages_ and added comment. -- To view, visit http://gerrit.cloudera.org:8080/11694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4a9098a2085a385351477c715ae245d83bf1c72 Gerrit-Change-Number: 11694 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 17 Oct 2018 15:55:07 +0000 Gerrit-HasComments: Yes
