Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11694 )
Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11694/2/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/11694/2/be/src/exec/hdfs-parquet-table-writer.cc@705 PS2, Line 705: num_data_pages_ > Turned out 'num_data_pages_' can be less than 'pages_.size()' since 'pages_ Can you add a comment to this loop to explain why we don't use a range-based loop here? Maybe even add a DCHECK_LE(num_data_pages_, pages.size()) for good measure)? If you can think of an easy way to make it easier for us to prevent this mistake in the future, that'd be nice. -- To view, visit http://gerrit.cloudera.org:8080/11694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4a9098a2085a385351477c715ae245d83bf1c72 Gerrit-Change-Number: 11694 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 16 Oct 2018 15:45:19 +0000 Gerrit-HasComments: Yes
