Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 )
Change subject: IMPALA-6323 Allow constant analytic window expressions. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11556/5/be/src/exec/analytic-eval-node.cc File be/src/exec/analytic-eval-node.cc: http://gerrit.cloudera.org:8080/#/c/11556/5/be/src/exec/analytic-eval-node.cc@397 PS5, Line 397: && !(order_by_eq_expr_eval_ == nullptr || > I think we should try to remove this extra code path (multiple equivalent c I can look into that, but at first glance it seems sneaky. I'd prefer to rely on doing this explicitly as is, instead of leveraging a side-effect for nefarious purposes. -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 5 Gerrit-Owner: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 23 Oct 2018 02:18:15 +0000 Gerrit-HasComments: Yes
