Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11596 )
Change subject: IMPALA-7662: fix error race when scanner open fails ...................................................................... Patch Set 7: Code-Review+1 (3 comments) Just some nits. http://gerrit.cloudera.org:8080/#/c/11596/7/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: http://gerrit.cloudera.org:8080/#/c/11596/7/be/src/exec/hdfs-scan-node-base.h@564 PS7, Line 564: /// - If the scanner is created but opening fails, returns an error sets *scanner. The nit: missing and? http://gerrit.cloudera.org:8080/#/c/11596/7/be/src/exec/hdfs-scan-node-base.h@565 PS7, Line 565: /// caller is then responsible for closing the scanner nit: missing . http://gerrit.cloudera.org:8080/#/c/11596/7/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/11596/7/tests/query_test/test_scanners.py@732 PS7, Line 732: del vector.get_value('exec_option')['debug_action'] Can you explain why this line is needed? -- To view, visit http://gerrit.cloudera.org:8080/11596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45a61210ca7d057b048c77d9f2f2695ec450f19b Gerrit-Change-Number: 11596 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 24 Oct 2018 15:38:17 +0000 Gerrit-HasComments: Yes
