Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11596 )
Change subject: IMPALA-7662: fix error race when scanner open fails ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node-base.h@562 PS8, Line 562: open > nit: opened Done http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node.cc@491 PS8, Line 491: scanner->Close() call marks a scan range as complete > if this is true for all hdfs scan nodes, maybe add this to the method comme Done http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node.cc@498 PS8, Line 498: scanner > Ignore comment, just saw that boost overloads it Yeah "ptr.get() == nullptr" seems to be the dominant style in the codebase but I think it just adds noise compared to "ptr == nullptr". At one point I tried to convince people to use this style instead but I wasn't successful - apparently it's too magical (unlike all the other smart pointer operator overloads...). http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node.cc@535 PS8, Line 535: } > L492-498 and L524-531 do pretty much the same thing and have the same comme Done. I think it makes sense. http://gerrit.cloudera.org:8080/#/c/11596/8/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/11596/8/tests/query_test/test_scanners.py@733 PS8, Line 733: del vector.get_value('exec_option')['debug_action'] > dont we skip the test above if this is set? I wasn't sure if there was a difference between it being set to None and it not being present in the vector. I tested it out and it looks like the .test file can still set it fine with this line removed. -- To view, visit http://gerrit.cloudera.org:8080/11596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45a61210ca7d057b048c77d9f2f2695ec450f19b Gerrit-Change-Number: 11596 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 26 Oct 2018 17:07:53 +0000 Gerrit-HasComments: Yes
