Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11596 )
Change subject: IMPALA-7662: fix error race when scanner open fails ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node-base.h@562 PS8, Line 562: open nit: opened http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node.cc@491 PS8, Line 491: scanner->Close() call marks a scan range as complete if this is true for all hdfs scan nodes, maybe add this to the method comment of HdfsScanner::Close() http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node.cc@498 PS8, Line 498: scanner scanner.get() http://gerrit.cloudera.org:8080/#/c/11596/8/be/src/exec/hdfs-scan-node.cc@535 PS8, Line 535: } L492-498 and L524-531 do pretty much the same thing and have the same comments. Maybe extract it in a helper method? or will that be an overkill? http://gerrit.cloudera.org:8080/#/c/11596/8/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/11596/8/tests/query_test/test_scanners.py@733 PS8, Line 733: del vector.get_value('exec_option')['debug_action'] dont we skip the test above if this is set? -- To view, visit http://gerrit.cloudera.org:8080/11596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45a61210ca7d057b048c77d9f2f2695ec450f19b Gerrit-Change-Number: 11596 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 26 Oct 2018 02:19:05 +0000 Gerrit-HasComments: Yes
