Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11762 )
Change subject: IMPALA-7742: Stores the Sentry user names in a case sensitive way ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/11762/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11762/1//COMMIT_MSG@11 PS1, Line 11: stores nit: store http://gerrit.cloudera.org:8080/#/c/11762/1/fe/src/main/java/org/apache/impala/catalog/User.java File fe/src/main/java/org/apache/impala/catalog/User.java: http://gerrit.cloudera.org:8080/#/c/11762/1/fe/src/main/java/org/apache/impala/catalog/User.java@41 PS1, Line 41: true isn't this the one that needs to be switched to false? does it make sense to have a public static method for this... the protected method here can just use it, and it would be it more obvious when initializing the cache in AuthorizationPolicy. There you would use something like... new Cache...(User.isCaseInsensitiveKeys()) http://gerrit.cloudera.org:8080/#/c/11762/1/fe/src/test/java/org/apache/impala/service/CustomClusterGroupMapper.java File fe/src/test/java/org/apache/impala/service/CustomClusterGroupMapper.java: http://gerrit.cloudera.org:8080/#/c/11762/1/fe/src/test/java/org/apache/impala/service/CustomClusterGroupMapper.java@59 PS1, Line 59: FOOBAR what is being tested with case sensitive group names? http://gerrit.cloudera.org:8080/#/c/11762/1/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/11762/1/tests/authorization/test_owner_privileges.py@414 PS1, Line 414: cases nit: case http://gerrit.cloudera.org:8080/#/c/11762/1/tests/authorization/test_owner_privileges.py@418 PS1, Line 418: FOOBAR_impalad_client = self.create_impala_client() why are two clients needed? -- To view, visit http://gerrit.cloudera.org:8080/11762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04bec045e3f70fc4f41b16b9b5c55eeb60bd63b8 Gerrit-Change-Number: 11762 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 26 Oct 2018 18:26:08 +0000 Gerrit-HasComments: Yes
