Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11762 )
Change subject: IMPALA-7742: Stores the Sentry user names in a case sensitive way ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11762/2/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java File fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java: http://gerrit.cloudera.org:8080/#/c/11762/2/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java@80 PS2, Line 80: false something seems out of alignment here and http://github.mtv.cloudera.com/CDH/Impala/blob/67bde8e6b2ed758de02ef04ec27b15a4a3bc8a5c/fe/src/main/java/org/apache/impala/catalog/Principal.java#L42 fwict, we have CatalogObjectCaches for users, roles (in authorization policy), and abstractly their privs in the super-class, Principals. Here, users are keyed case sensitive whereas in Principals, privs are keyed case insensitive. why's that? http://gerrit.cloudera.org:8080/#/c/11762/1/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/11762/1/tests/authorization/test_owner_privileges.py@418 PS1, Line 418: FOOBAR_impalad_client = self.create_impala_client() > Yeah it's a bit weird but that's because a session is a connection to a par that's for running against test files. what breaks if the same client is used? if that "user" param modifies some state (e.g., on L425), that's not obvious. -- To view, visit http://gerrit.cloudera.org:8080/11762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04bec045e3f70fc4f41b16b9b5c55eeb60bd63b8 Gerrit-Change-Number: 11762 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 26 Oct 2018 20:57:10 +0000 Gerrit-HasComments: Yes
