Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11762 )
Change subject: IMPALA-7742: Store the Sentry user names in a case sensitive way ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11762/2/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java File fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java: http://gerrit.cloudera.org:8080/#/c/11762/2/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java@80 PS2, Line 80: false > something seems out of alignment here and http://github.mtv.cloudera.com/CD Yes, that's how it works in Sentry. Privilege names regardless whether they are for users are roles are case insensitive (always in lower case in Sentry). Role names are case insensitive (always in lower case in Sentry), and user names are case sensitive. http://gerrit.cloudera.org:8080/#/c/11762/1/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/11762/1/tests/authorization/test_owner_privileges.py@418 PS1, Line 418: FOOBAR_impalad_client = self.create_impala_client() > that's for running against test files. what breaks if the same client is us Yeah I know it's for running against tests files. I was trying to give an example why it needs a separate client like the case with using USER in a test file. Using the same Impala client breaks because the Impala client will assume foobar_impalad_client uses "foobar" user even though we explicitly pass "FOOBAR". It seems passing user attribute is "sticky". What it means is the first user passed will be used and any subsequent queries will use that user regardless whether we pass a different user. There maybe a bug somewhere in the existing test framework. -- To view, visit http://gerrit.cloudera.org:8080/11762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04bec045e3f70fc4f41b16b9b5c55eeb60bd63b8 Gerrit-Change-Number: 11762 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 26 Oct 2018 23:13:00 +0000 Gerrit-HasComments: Yes
