Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11596 )
Change subject: IMPALA-7662: fix error race when scanner open fails ...................................................................... Patch Set 11: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/11596/10/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11596/10/be/src/exec/hdfs-scan-node.cc@515 PS10, Line 515: // If status is the first non-ok status returned by any scanner thread, update : // HdfsScanNodeBase::status_ variable and notify other scanner threads. Ensure that : // status_ is updated before marking a range as complete (The scanner->Close() call : // marks a scan range as complete). > nit: should we remove this comment here and above considering that its ment I wanted to keep this here since it's documenting the order requirement between the two statements here. Maybe it's a bit verbose but it's subtle enough it seems worthwhile to keep. http://gerrit.cloudera.org:8080/#/c/11596/10/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: http://gerrit.cloudera.org:8080/#/c/11596/10/be/src/exec/hdfs-scanner.h@151 PS10, Line 151: complete > nit: can close the scan even if it didnt process it. Maybe just say somethi Done -- To view, visit http://gerrit.cloudera.org:8080/11596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45a61210ca7d057b048c77d9f2f2695ec450f19b Gerrit-Change-Number: 11596 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 26 Oct 2018 19:02:59 +0000 Gerrit-HasComments: Yes
