Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11806 )
Change subject: IMPALA-7749: (Part 1/2) Improve AggregationNode's memory estimates ...................................................................... Patch Set 1: (2 comments) The code change looks good, I just had a couple of suggestions about the commit message and commits. I can start the merge once those are addressed. http://gerrit.cloudera.org:8080/#/c/11806/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11806/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-7749: (Part 1/2) Improve AggregationNode's memory estimates I think it would be better to file a separate JIRA for part 2. Part 1 is kinda a bug fix and it's nice to be able to track which version those are fixed in based on JIRA number. http://gerrit.cloudera.org:8080/#/c/11806/1/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test File testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test: http://gerrit.cloudera.org:8080/#/c/11806/1/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test@5473 PS1, Line 5473: # Aggregation with a limit should compute memory estimates based on input cardinality. Probably worth mentioning the JIRA for motivation -- To view, visit http://gerrit.cloudera.org:8080/11806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd95d2ad5b677fca459c9c32b98f6176842161fc Gerrit-Change-Number: 11806 Gerrit-PatchSet: 1 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 29 Oct 2018 02:59:26 +0000 Gerrit-HasComments: Yes
