Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11806 )
Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality ...................................................................... IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality Prior to this change, the AggregationNode's perInstanceCardinality was influenced by the node's selectivity and limit. This was incorrect because the hash table is constructed over the entire input stream before any row batches are produced. This change ensures that the input cardinality is used to determine the perInstanceCardinality. Testing: Added a planner test which ensures that an AggregationNode with a limit estimates memory based on the input cardinality. Ran front-end and end-to-end tests affected by this change. Change-Id: Ifd95d2ad5b677fca459c9c32b98f6176842161fc Reviewed-on: http://gerrit.cloudera.org:8080/11806 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/planner/AggregationNode.java M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test M testdata/workloads/functional-planner/queries/PlannerTest/tpch-all.test 3 files changed, 99 insertions(+), 21 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifd95d2ad5b677fca459c9c32b98f6176842161fc Gerrit-Change-Number: 11806 Gerrit-PatchSet: 4 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
