Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11806 )
Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11806/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11806/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality > I think it would be better to file a separate JIRA for part 2. Part 1 is ki Done http://gerrit.cloudera.org:8080/#/c/11806/1/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test File testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test: http://gerrit.cloudera.org:8080/#/c/11806/1/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test@5473 PS1, Line 5473: # IMPALA-7749: Aggregation with a limit should compute memory estimates based on input > Probably worth mentioning the JIRA for motivation Done -- To view, visit http://gerrit.cloudera.org:8080/11806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd95d2ad5b677fca459c9c32b98f6176842161fc Gerrit-Change-Number: 11806 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 29 Oct 2018 16:42:27 +0000 Gerrit-HasComments: Yes
