Pooja Nilangekar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11816 )

Change subject: IMPALA-7735: Expose queuing status in ExecSummary and 
impala-shell
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11816/1/tests/custom_cluster/test_shell_interactive.py
File tests/custom_cluster/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/11816/1/tests/custom_cluster/test_shell_interactive.py@38
PS1, Line 38: proc = pexpect.spawn(' '.join([SHELL_CMD, "-i localhost:21000"]))
I think it would help connecting to another port (i.e. another impalad) to 
ensure that the admission controller status is propagated across impalads. (Not 
sure if it'd make things flaky though).



--
To view, visit http://gerrit.cloudera.org:8080/11816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibde447b01559b9f0f3e970d4fa10f6ee4064bd49
Gerrit-Change-Number: 11816
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Oct 2018 19:24:48 +0000
Gerrit-HasComments: Yes

Reply via email to