Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 )
Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell ...................................................................... Patch Set 1: Code-Review+2 (6 comments) http://gerrit.cloudera.org:8080/#/c/11816/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11816/1//COMMIT_MSG@9 PS1, Line 9: This patch adds the queuing status, that is, whether the query was > Can you mention that this is showed when either live_summary or live_progre yup, thats already mentioned at the end of this paragraph http://gerrit.cloudera.org:8080/#/c/11816/1/common/thrift/ExecStats.thrift File common/thrift/ExecStats.thrift: http://gerrit.cloudera.org:8080/#/c/11816/1/common/thrift/ExecStats.thrift@104 PS1, Line 104: queued > "is currently queued by admission control" to be totally clear Done http://gerrit.cloudera.org:8080/#/c/11816/1/common/thrift/ExecStats.thrift@107 PS1, Line 107: // Contains the latest queuing reason if the query is queued. > Same as above. Done http://gerrit.cloudera.org:8080/#/c/11816/1/tests/custom_cluster/test_shell_interactive.py File tests/custom_cluster/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/11816/1/tests/custom_cluster/test_shell_interactive.py@26 PS1, Line 26: class TestShellInteractive(CustomClusterTestSuite): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/11816/1/tests/custom_cluster/test_shell_interactive.py@29 PS1, Line 29: > flake8: E251 unexpected spaces around keyword / parameter equals Done http://gerrit.cloudera.org:8080/#/c/11816/1/tests/custom_cluster/test_shell_interactive.py@38 PS1, Line 38: proc = pexpect.spawn(' '.join([SHELL_CMD, "-i localhost:21000"])) > I think it would help connecting to another port (i.e. another impalad) to Good point! but we already have tests that rely on pool stats being propagated across the cluster -- To view, visit http://gerrit.cloudera.org:8080/11816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibde447b01559b9f0f3e970d4fa10f6ee4064bd49 Gerrit-Change-Number: 11816 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 29 Oct 2018 21:58:21 +0000 Gerrit-HasComments: Yes
