Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 )
Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell ...................................................................... Patch Set 1: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/11816/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11816/1//COMMIT_MSG@9 PS1, Line 9: This patch adds the queuing status, that is, whether the query was Can you mention that this is showed when either live_summary or live_progress is true. http://gerrit.cloudera.org:8080/#/c/11816/1/common/thrift/ExecStats.thrift File common/thrift/ExecStats.thrift: http://gerrit.cloudera.org:8080/#/c/11816/1/common/thrift/ExecStats.thrift@104 PS1, Line 104: queued "is currently queued by admission control" to be totally clear http://gerrit.cloudera.org:8080/#/c/11816/1/common/thrift/ExecStats.thrift@107 PS1, Line 107: // Contains the latest queuing reason if the query is queued. Same as above. http://gerrit.cloudera.org:8080/#/c/11816/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/11816/1/shell/impala_shell.py@969 PS1, Line 969: if summary.is_queued: It's a little subtle that this handles both None and False. I'll leave it up to you whether this is worth documenting. -- To view, visit http://gerrit.cloudera.org:8080/11816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibde447b01559b9f0f3e970d4fa10f6ee4064bd49 Gerrit-Change-Number: 11816 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 29 Oct 2018 20:40:01 +0000 Gerrit-HasComments: Yes
