Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11853 )
Change subject: IMPALA-7244: [DOCS] Impala supports ADSL Gen 2 (ABFS) ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11853/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/11853/1/docs/shared/impala_common.xml@1304 PS1, Line 1304: Gen2 Use "Gen 2" rather than "Gen2" http://gerrit.cloudera.org:8080/#/c/11853/1/docs/shared/impala_common.xml@1310 PS1, Line 1310: Gen2 Nit: We seem to use "Gen 1"/"Gen 2" rather than "Gen1"/"Gen2" in other docs. Let's use "Gen 2" here as well. (Or whichever form we choose, be consistent.) http://gerrit.cloudera.org:8080/#/c/11853/1/docs/topics/impala_adls.xml File docs/topics/impala_adls.xml: http://gerrit.cloudera.org:8080/#/c/11853/1/docs/topics/impala_adls.xml@99 PS1, Line 99: <codeblock>abfs://<varname>your_account</varname>.azuredatalakestore.net/<varname>rest_of_directory_path</varname> : abfss://<varname>your_account</varname>.azuredatalakestore.net/<varname>rest_of_directory_path</varname> The URI format is not the same as ADLS Gen 1. This link describes the new URI: https://docs.microsoft.com/en-us/azure/storage/data-lake-storage/introduction-abfs-uri Here's an example for our tests: https://github.com/apache/impala/blob/master/bin/impala-config.sh#L376-L377 So, we need to change all these links to be of the form: abfss://[container_name]@[account_name].dfs.core.windows.net/rest_of_directory_path In particular, the container_name is new to ABFS. Do we want to have a sentence noting the difference between abfs:// and abfss:// (i.e. that abfss uses a secure connection) ? -- To view, visit http://gerrit.cloudera.org:8080/11853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic06d9ac92ed78b9092369e211de8a81db1d7ce90 Gerrit-Change-Number: 11853 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 21:01:02 +0000 Gerrit-HasComments: Yes
