Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11853 )
Change subject: IMPALA-7244: [DOCS] Impala supports ADLS Gen 2 (ABFS) ...................................................................... Patch Set 3: (4 comments) A few minor comments. http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_adls.xml File docs/topics/impala_adls.xml: http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_adls.xml@94 PS3, Line 94: abfs(s):// Nit: I think it would make more sense to split this out. http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_adls.xml@166 PS3, Line 166: <p>For ADLS Gen2:</p> : <codeblock> <property> : <name>fs.azure.account.auth.type</name> : <value>OAuth</value> : </property> : : <property> : <name>fs.azure.account.oauth.provider.type</name> : <value>org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider</value> : </property> : : <property> : <name>fs.azure.account.oauth2.client.id</name> : <value><varname>your_client_id</varname></value> : </property> : : <property> : <name>fs.azure.account.oauth2.client.secret</name> : <value><varname>your_client_secret</varname></value> : </property> : : <property> : <name>fs.azure.account.oauth2.client.endpoint</name> : <value>https://login.microsoftonline.com/<varname>your_azure_tenant_id</varname>/oauth2/token</value> : </property></codeblock> Double-checked this, and it matches what we are doing in core-site.xml for our tests. http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_insert.xml File docs/topics/impala_insert.xml: http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_insert.xml@567 PS3, Line 567: <p : conref="../shared/impala_common.xml#common/insert_hidden_work_directory"/> Nit: Do we need these whitespace-only changes? http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_insert.xml@658 PS3, Line 658: <p : conref="../shared/impala_common.xml#common/char_varchar_cast_from_string"/> : : <p conref="../shared/impala_common.xml#common/related_options"/> : : <p rev="1.3.1" : conref="../shared/impala_common.xml#common/insert_inherit_permissions"/> Same here: whitespace-only changes -- To view, visit http://gerrit.cloudera.org:8080/11853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic06d9ac92ed78b9092369e211de8a81db1d7ce90 Gerrit-Change-Number: 11853 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 06 Nov 2018 01:05:13 +0000 Gerrit-HasComments: Yes
