Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11853 )
Change subject: IMPALA-7244: [DOCS] Impala supports ADLS Gen 2 (ABFS) ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11853/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/11853/1/docs/shared/impala_common.xml@1304 PS1, Line 1304: Gen2 > Use "Gen 2" rather than "Gen2" I checked the MS docs, and they use "Gen2". I will consistently use "Gen2" to match the MS official naming. http://gerrit.cloudera.org:8080/#/c/11853/1/docs/shared/impala_common.xml@1310 PS1, Line 1310: Gen2 > Nit: We seem to use "Gen 1"/"Gen 2" rather than "Gen1"/"Gen2" in other docs Will be consistent with "Gen2" http://gerrit.cloudera.org:8080/#/c/11853/1/docs/topics/impala_adls.xml File docs/topics/impala_adls.xml: http://gerrit.cloudera.org:8080/#/c/11853/1/docs/topics/impala_adls.xml@99 PS1, Line 99: <codeblock>abfs://<varname>your_account</varname>.azuredatalakestore.net/<varname>rest_of_directory_path</varname> : abfss://<varname>your_account</varname>.azuredatalakestore.net/<varname>rest_of_directory_path</varname> > The URI format is not the same as ADLS Gen 1. This link describes the new U Removed here and fixed in the section below, CREATE DB and TABLES. http://gerrit.cloudera.org:8080/#/c/11853/2/docs/topics/impala_adls.xml File docs/topics/impala_adls.xml: http://gerrit.cloudera.org:8080/#/c/11853/2/docs/topics/impala_adls.xml@92 PS2, Line 92: <codeph>abfs(s)://</codeph> for ADLS Gen 2, for the > nit: let's expand it out "abfs:// or abfss://". Moved below and expanded - CREAT TABLE section. -- To view, visit http://gerrit.cloudera.org:8080/11853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic06d9ac92ed78b9092369e211de8a81db1d7ce90 Gerrit-Change-Number: 11853 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 23:06:59 +0000 Gerrit-HasComments: Yes
