Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 )
Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots ...................................................................... Patch Set 3: (9 comments) Looking good, mainly had minor comments. http://gerrit.cloudera.org:8080/#/c/11599/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11599/3//COMMIT_MSG@18 PS3, Line 18: Performance tests on TPCH-40 produced 3.96% improvement. I'm curious why this is so different from your earlier results on scale factor 60 - was there an issue with the previous results? Or does the larger scale factor or different system make a big difference? http://gerrit.cloudera.org:8080/#/c/11599/3/be/src/exec/text-converter.inline.h File be/src/exec/text-converter.inline.h: http://gerrit.cloudera.org:8080/#/c/11599/3/be/src/exec/text-converter.inline.h@86 PS3, Line 86: UnescapeString(data, str.ptr, &str.len, buffer_len); // NOLINT Can you add a brief comment explaining the NOLINT. Or maybe there's a reasonable way to work around it like using a temporary value on the stack? http://gerrit.cloudera.org:8080/#/c/11599/3/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/11599/3/be/src/exprs/expr-test.cc@7610 PS3, Line 7610: // Test layout adding a bunch of exprs. This is designed to trigger padding. Update comment - maybe mention that it was padded in the past but that now it isn't http://gerrit.cloudera.org:8080/#/c/11599/3/be/src/exprs/expr-test.cc@7656 PS3, Line 7656: // ASSERT_EQ(expected_byte_size % 8, 0); Remove? http://gerrit.cloudera.org:8080/#/c/11599/3/be/src/exprs/scalar-expr.cc File be/src/exprs/scalar-expr.cc: http://gerrit.cloudera.org:8080/#/c/11599/3/be/src/exprs/scalar-expr.cc@228 PS3, Line 228: // TODO: sort by type as well? Any reason to do this? Remove these TODOs? http://gerrit.cloudera.org:8080/#/c/11599/3/be/src/exprs/scalar-expr.cc@262 PS3, Line 262: // Walk the types and store in a packed aligned layout Stale comment? http://gerrit.cloudera.org:8080/#/c/11599/3/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java File fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java: http://gerrit.cloudera.org:8080/#/c/11599/3/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java@275 PS3, Line 275: nit: unnecessary/inconsistent vertical whitespace http://gerrit.cloudera.org:8080/#/c/11599/3/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java@347 PS3, Line 347: private boolean isKuduStringSlot(SlotDescriptor slot) { Wouldn't it make more sense for this to be a SlotDescriptor method? It looks like SlotDescriptor has a reference to the parent TupleDescriptor. http://gerrit.cloudera.org:8080/#/c/11599/3/testdata/workloads/functional-planner/queries/PlannerTest/join-order.test File testdata/workloads/functional-planner/queries/PlannerTest/join-order.test: http://gerrit.cloudera.org:8080/#/c/11599/3/testdata/workloads/functional-planner/queries/PlannerTest/join-order.test@546 PS3, Line 546: # the largest input is prevented from becoming the leftmost input by the full outer join This and the similar one below are outdated, I think from a time when the planner didn't invert some joins - maybe just remove them? -- To view, visit http://gerrit.cloudera.org:8080/11599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32f3b06622c087e4aa288e8db1bf4581b10d386a Gerrit-Change-Number: 11599 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 14 Nov 2018 01:21:31 +0000 Gerrit-HasComments: Yes
