Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 )
Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots ...................................................................... Patch Set 4: (2 comments) looks good, I'll let Tim +2 after you have addressed his latest comment. http://gerrit.cloudera.org:8080/#/c/11599/4/be/src/exec/text-converter.inline.h File be/src/exec/text-converter.inline.h: http://gerrit.cloudera.org:8080/#/c/11599/4/be/src/exec/text-converter.inline.h@86 PS4, Line 86: int str_len = str.len; nit: can you still add a short comment here explaining the local variable, since its not immediately obvious why this workaround is necessary http://gerrit.cloudera.org:8080/#/c/11599/4/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/11599/4/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@186 PS4, Line 186: /VARCHAR nit: I believe varchar is not supported in kudu -- To view, visit http://gerrit.cloudera.org:8080/11599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32f3b06622c087e4aa288e8db1bf4581b10d386a Gerrit-Change-Number: 11599 Gerrit-PatchSet: 4 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 15 Nov 2018 02:21:15 +0000 Gerrit-HasComments: Yes
