Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 )
Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11599/3/testdata/workloads/functional-planner/queries/PlannerTest/join-order.test File testdata/workloads/functional-planner/queries/PlannerTest/join-order.test: http://gerrit.cloudera.org:8080/#/c/11599/3/testdata/workloads/functional-planner/queries/PlannerTest/join-order.test@546 PS3, Line 546: # order does not become the leftmost input because of the outer join; > Done Sorry to be unclear - I think we should keep the test (it's useful to be able to look at the history and see how the plan changed over time) but remove the comment. -- To view, visit http://gerrit.cloudera.org:8080/11599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32f3b06622c087e4aa288e8db1bf4581b10d386a Gerrit-Change-Number: 11599 Gerrit-PatchSet: 4 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 15 Nov 2018 00:59:52 +0000 Gerrit-HasComments: Yes
