Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12021 )
Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue() ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Just some nits, lgtm otherwise http://gerrit.cloudera.org:8080/#/c/12021/1/be/src/runtime/raw-value.cc File be/src/runtime/raw-value.cc: http://gerrit.cloudera.org:8080/#/c/12021/1/be/src/runtime/raw-value.cc@111 PS1, Line 111: Intermediate UDA step You could add some explicit hint about the fact that this is not a value, e.g "Intermediate UDA step, no value printed". http://gerrit.cloudera.org:8080/#/c/12021/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12021/1/tests/webserver/test_web_pages.py@248 PS1, Line 248: v what does 'v' mean here? http://gerrit.cloudera.org:8080/#/c/12021/1/tests/webserver/test_web_pages.py@250 PS1, Line 250: emptytable Is there a specific reason for using emptytable? I guess that this makes the test faster, but I think that optimizations in the future may cause Impala to skip the code we want to test here. -- To view, visit http://gerrit.cloudera.org:8080/12021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22fe7cbbadd0c7eb6d0bd2d50bf500f0528e6af0 Gerrit-Change-Number: 12021 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 01 Dec 2018 14:44:52 +0000 Gerrit-HasComments: Yes
