Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12021 )
Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue() ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12021/1/be/src/runtime/raw-value.cc File be/src/runtime/raw-value.cc: http://gerrit.cloudera.org:8080/#/c/12021/1/be/src/runtime/raw-value.cc@111 PS1, Line 111: Intermediate UDA step > You could add some explicit hint about the fact that this is not a value, e Done http://gerrit.cloudera.org:8080/#/c/12021/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12021/1/tests/webserver/test_web_pages.py@248 PS1, Line 248: v > what does 'v' mean here? that's a check on the web page content. Basically verifies that the following or similar is present: "Glog level for --v set to 3 Default glog level: 1" (Copy-pasted from the test above to be honest:) ) http://gerrit.cloudera.org:8080/#/c/12021/1/tests/webserver/test_web_pages.py@250 PS1, Line 250: onal.allty > Is there a specific reason for using emptytable? I guess that this makes th We can be on the cautious side here, sure. I changed this to use alltypessmall. -- To view, visit http://gerrit.cloudera.org:8080/12021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22fe7cbbadd0c7eb6d0bd2d50bf500f0528e6af0 Gerrit-Change-Number: 12021 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 03 Dec 2018 11:40:05 +0000 Gerrit-HasComments: Yes
