Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12021
to look at the new patch set (#2).
Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()
......................................................................
IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()
Occasionally Impala crashed on a DCHECK in RawValue::PrintValue()
when running web pages tests. Turned out that queries that have an
intermediate step for aggregation hit that DCHECK failure when the
log level is set to 3. As these web pages test run in parallel it
happened sometimes that a selective query was run after test_log_level
set the log level to 3 but before it came to the point to reset it.
The solution was to enhance RawValue::PrintValue() to handle
TYPE_FIXED_UDA_INTERMEDIATE not to run on the default case of the
switch.
In addition I extended the log writing for this DCHECK to print out
the type it can't handle.
Testing:
- Extended the web server tests to set the log level to 3 and to
run an aggregating query in the same test.
Change-Id: I22fe7cbbadd0c7eb6d0bd2d50bf500f0528e6af0
---
M be/src/runtime/raw-value.cc
M tests/webserver/test_web_pages.py
2 files changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/12021/2
--
To view, visit http://gerrit.cloudera.org:8080/12021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22fe7cbbadd0c7eb6d0bd2d50bf500f0528e6af0
Gerrit-Change-Number: 12021
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
