Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 )
Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement ...................................................................... Patch Set 3: Code-Review+1 (2 comments) few nits, lgtm otherwise http://gerrit.cloudera.org:8080/#/c/12052/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12052/3//COMMIT_MSG@16 PS3, Line 16: "update" in will be categorized as DML even though the token is part of nit: missing 'it'? http://gerrit.cloudera.org:8080/#/c/12052/3/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/12052/3/tests/shell/test_shell_interactive.py@747 PS3, Line 747: alltypes nit: querying alltypestiny or emptytable (it has a string column) could make the test slightly faster -- To view, visit http://gerrit.cloudera.org:8080/12052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I011b8e73a0477ac6b2357725452458f972785ae7 Gerrit-Change-Number: 12052 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Dec 2018 16:35:21 +0000 Gerrit-HasComments: Yes
