Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 )
Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Carry Csaba's +1. http://gerrit.cloudera.org:8080/#/c/12052/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12052/3//COMMIT_MSG@16 PS3, Line 16: "update" it in will be categorized as DML even though the token is part > nit: missing 'it'? Done http://gerrit.cloudera.org:8080/#/c/12052/3/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/12052/3/tests/shell/test_shell_interactive.py@747 PS3, Line 747: alltypes > nit: querying alltypestiny or emptytable (it has a string column) could mak Done -- To view, visit http://gerrit.cloudera.org:8080/12052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I011b8e73a0477ac6b2357725452458f972785ae7 Gerrit-Change-Number: 12052 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Comment-Date: Fri, 07 Dec 2018 16:56:19 +0000 Gerrit-HasComments: Yes
