Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 )
Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/12052/5/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/12052/5/shell/impala_shell.py@1148 PS5, Line 1148: # to deal with escaped quotes in string literals Appears you are breaking this if you use non-posix mode. with x as (select 1) select '\'update\'' I don't have a good suggestion on how to fix it though. Using a simple lexer to parse a SQL query sounds broken. Wondering if we can do this via sqlparse (I haven't looked at it though). http://gerrit.cloudera.org:8080/#/c/12052/5/shell/impala_shell.py@1151 PS5, Line 1151: lexer.escapedquotes += "'" Per docs, doesn't apply in non-posix mode. http://gerrit.cloudera.org:8080/#/c/12052/5/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/12052/5/tests/shell/test_shell_interactive.py@744 PS5, Line 744: for keyword in ["insert", "upsert", "update", "delete"]: Update this to include escaped quotes/strings if you fix it. -- To view, visit http://gerrit.cloudera.org:8080/12052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I011b8e73a0477ac6b2357725452458f972785ae7 Gerrit-Change-Number: 12052 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 05:28:26 +0000 Gerrit-HasComments: Yes
