Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12047 )
Change subject: IMPALA-6591: Fix test_ssl flaky test ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/12047/2/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: http://gerrit.cloudera.org:8080/#/c/12047/2/tests/custom_cluster/test_client_ssl.py@88 PS2, Line 88: p = ImpalaShell(args="--ssl") > How many places would these be? I think the behavior should really be wait Done http://gerrit.cloudera.org:8080/#/c/12047/4/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/12047/4/tests/shell/util.py@128 PS4, Line 128: or will wait until : Impala shell is connected for the specified timeout unless wait_util_connected is : set to False o > I don't think this second sentence is necessary. Done http://gerrit.cloudera.org:8080/#/c/12047/4/tests/shell/util.py@132 PS4, Line 132: self.shell_process = self._start_new_shell_process(args, env=env) > This should have a timeout. It can be high (5min) but that will make a hang Updated the CR but using 1 minute as the default. Done. -- To view, visit http://gerrit.cloudera.org:8080/12047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9805269d8b806aecf5d744c219967649a041d49f Gerrit-Change-Number: 12047 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Tue, 11 Dec 2018 14:49:36 +0000 Gerrit-HasComments: Yes
