Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12047 )
Change subject: IMPALA-6591: Fix test_ssl flaky test ...................................................................... Patch Set 6: (3 comments) Some small readability nits but otherwise lgtm http://gerrit.cloudera.org:8080/#/c/12047/6/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/12047/6/tests/shell/util.py@97 PS6, Line 97: False if not expect_success : else wait_until_connected This looks equivalent to "expect_success and wait_until_connected". I think it might be more readable to define a new variable above, and it'll likely use the same number of lines. http://gerrit.cloudera.org:8080/#/c/12047/6/tests/shell/util.py@138 PS6, Line 138: args is None or "--quiet" not in args) You can simplify this to args and "--quiet" not in args The difference between "not args" and "args is None" doesn't matter here. http://gerrit.cloudera.org:8080/#/c/12047/6/tests/shell/util.py@141 PS6, Line 141: while time.time() - start_time < timeout: You could also do: while ... and not connected: and remove the if: break, but I'm fine with either way. -- To view, visit http://gerrit.cloudera.org:8080/12047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9805269d8b806aecf5d744c219967649a041d49f Gerrit-Change-Number: 12047 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Wed, 12 Dec 2018 04:35:46 +0000 Gerrit-HasComments: Yes
