Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12047 )
Change subject: IMPALA-6591: Fix test_ssl flaky test ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/12047/6/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/12047/6/tests/shell/util.py@97 PS6, Line 97: expect_success and wait_until_connected) : if expect_success: > This looks equivalent to "expect_success and wait_until_connected". I think Done http://gerrit.cloudera.org:8080/#/c/12047/6/tests/shell/util.py@138 PS6, Line 138: > You can simplify this to I don't think it's quite the same. When args is None, we also want the shell to wait until it's connected. With args and "--quiet" not in args, the constructor will not wait. http://gerrit.cloudera.org:8080/#/c/12047/6/tests/shell/util.py@141 PS6, Line 141: connected = "Connected to" in self.shell_process.stderr.readline() > You could also do: Your suggestion is nicer. Done. -- To view, visit http://gerrit.cloudera.org:8080/12047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9805269d8b806aecf5d744c219967649a041d49f Gerrit-Change-Number: 12047 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Wed, 12 Dec 2018 18:25:37 +0000 Gerrit-HasComments: Yes
