Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12136 )

Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output
......................................................................


Patch Set 15:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12136/15/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

http://gerrit.cloudera.org:8080/#/c/12136/15/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@276
PS15, Line 276:       List<? extends FeFsPartition> partitions, TableRef 
hdfsTblRef, AggregateInfo aggInfo,
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/12136/15/fe/src/test/java/org/apache/impala/planner/PlannerTest.java
File fe/src/test/java/org/apache/impala/planner/PlannerTest.java:

http://gerrit.cloudera.org:8080/#/c/12136/15/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@729
PS15, Line 729:     assertEquals(" foo=bar cardinality=", filter.transform(" 
foo=bar cardinality=unavailable"));
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/12136/15/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@731
PS15, Line 731:     assertEquals(" row-size= cardinality=10.3K", 
filter.transform(" row-size=10B cardinality=10.3K"));
line too long (102 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/12136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9aa2d715b04cbb279aaffec8c5692686562d986
Gerrit-Change-Number: 12136
Gerrit-PatchSet: 15
Gerrit-Owner: Paul Rogers <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Paul Rogers <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 08 Jan 2019 20:14:14 +0000
Gerrit-HasComments: Yes

Reply via email to