Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 )
Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output ...................................................................... Patch Set 17: (1 comment) Bharath, thanks for the +2. Please hold off kicking off the final build until I verify that I've nailed all the test issues. Unfortunately, our pre-commit tests only catch one Python test failure per four-hour run, so it is a bit tedious to track down tests impacted by an EXPLAIN output change... I'l post here when the pre-review tests fully pass. http://gerrit.cloudera.org:8080/#/c/12136/17/fe/src/test/java/org/apache/impala/testutil/TestUtils.java File fe/src/test/java/org/apache/impala/testutil/TestUtils.java: http://gerrit.cloudera.org:8080/#/c/12136/17/fe/src/test/java/org/apache/impala/testutil/TestUtils.java@210 PS17, Line 210: try (Scanner e = new Scanner(expectedStr); > Just to be sure, there is no functional change here right? As I understand There is a functional change: one we need. The original version consumed two tokens per pass. Glance over at the left and look for the two a.next()/e.next() calls. Both consume a token. So, the original code didn't do what it claimed to do. The new code does work correctly. I retained this fix even though the original impetus for the fix, adding filtering, was removed. -- To view, visit http://gerrit.cloudera.org:8080/12136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9aa2d715b04cbb279aaffec8c5692686562d986 Gerrit-Change-Number: 12136 Gerrit-PatchSet: 17 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 19:11:16 +0000 Gerrit-HasComments: Yes
