Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 )
Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/12136/17/fe/src/test/java/org/apache/impala/testutil/TestUtils.java File fe/src/test/java/org/apache/impala/testutil/TestUtils.java: http://gerrit.cloudera.org:8080/#/c/12136/17/fe/src/test/java/org/apache/impala/testutil/TestUtils.java@210 PS17, Line 210: try (Scanner e = new Scanner(expectedStr); > There is a functional change: one we need. The original version consumed tw nice catch, that was subtle. Surprised we never hit this. Thanks for fixing. -- To view, visit http://gerrit.cloudera.org:8080/12136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9aa2d715b04cbb279aaffec8c5692686562d986 Gerrit-Change-Number: 12136 Gerrit-PatchSet: 17 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 12 Jan 2019 00:12:59 +0000 Gerrit-HasComments: Yes
