Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 )
Change subject: IMPALA-6664: Tag log statements with fragment or query ids. ...................................................................... Patch Set 3: > Does/should this fix up the Java side messages as well? May be some > configuration in Log4J that produces a result similar to what > you've achieved on the C++ side. The Java side of Impala logs to Glog via fe/src/main/java/org/apache/impala/util/GlogAppender.java which does JNI to write to GLOG. As a bonus, the log line below is an example of how we get this tagging for free assuming that the Java code isn't creating threads and so on. For the planner, it's single-threaded as far as I know, so we don't have to do anything special. I0108 10:39:16.456627 14752 Frontend.java:1282] 85420d575b9ff4b9:402b886800000000] Analysis finished. -- To view, visit http://gerrit.cloudera.org:8080/12129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6634ef9d1a7346339f24f2d40a7a3aa36a535da8 Gerrit-Change-Number: 12129 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 19:18:56 +0000 Gerrit-HasComments: No
