Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 )
Change subject: IMPALA-6664: Tag log statements with fragment or query ids. ...................................................................... Patch Set 4: (8 comments) I think I addressed all the comments. Please take another look. http://gerrit.cloudera.org:8080/#/c/12129/3/be/src/common/thread-debug-info.h File be/src/common/thread-debug-info.h: http://gerrit.cloudera.org:8080/#/c/12129/3/be/src/common/thread-debug-info.h@a94 PS3, Line 94: > We should copy parent_.thread_name_, or remove it from struct 'ParentInfo'. This was a bug (found by unit tests). Fixed. http://gerrit.cloudera.org:8080/#/c/12129/2/be/src/common/thread-debug-info.h File be/src/common/thread-debug-info.h: http://gerrit.cloudera.org:8080/#/c/12129/2/be/src/common/thread-debug-info.h@a116 PS2, Line 116: > Yeah, the idea was to make it readable when debugging a minidump or core fi Cool. I'll take a look at impala-gdb.py and fix it appropriately. Printing out the hex using gdb isn't too bad. I wrote down how to do it in gdb in debug-util.h for lack of a better place. Unit tests will be fixed in the next iteration. http://gerrit.cloudera.org:8080/#/c/12129/3/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/12129/3/be/src/exec/hdfs-scan-node-base.cc@37 PS3, Line 37: #include "exprs/scalar-expr-evaluator.h" > nit: do we need this include? Might be better to include it in hdfs-scan-no Done http://gerrit.cloudera.org:8080/#/c/12129/3/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/12129/3/be/src/exec/hdfs-scan-node.cc@325 PS3, Line 325: auto fn = [this, first_thread, scanner_thread_reservation]() { : this->ScannerThread(first_thread, scanner_thread_reservation); : }; : std::unique_ptr<Thread> t; : status = Thread::Create( > Since we use Thread::Create() later, https://github.com/apache/impala/blob/ No reason to believe it doesn't. I took this from some tracing code that I'm still working on. I tested this manually by adding an extra log message at the beginning of the scanner thread, and can confirm I can see it tagged. http://gerrit.cloudera.org:8080/#/c/12129/3/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/12129/3/be/src/runtime/io/disk-io-mgr.cc@424 PS3, Line 424: // We are now working on behalf of a query, so set thread state appropriately. : // See also IMPALA-6254 and IMPALA-6417. : ScopedThreadContext tdi_scope(GetThreadDebugInfo(), worker_context- > Fyi, IMPALA-6254 and IMPALA-6417 is about to make this automated. Maybe we Added a comment. http://gerrit.cloudera.org:8080/#/c/12129/3/tests/observability/test_log_fragments.py File tests/observability/test_log_fragments.py: http://gerrit.cloudera.org:8080/#/c/12129/3/tests/observability/test_log_fragments.py@23 PS3, Line 23: > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/12129/3/tests/observability/test_log_fragments.py@26 PS3, Line 26: > typo:fragments Done http://gerrit.cloudera.org:8080/#/c/12129/3/tests/observability/test_log_fragments.py@34 PS3, Line 34: """ > nit: result (since it's not a profile, rather an ImpalaBeeswaxResult) Done -- To view, visit http://gerrit.cloudera.org:8080/12129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6634ef9d1a7346339f24f2d40a7a3aa36a535da8 Gerrit-Change-Number: 12129 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Thu, 17 Jan 2019 20:01:09 +0000 Gerrit-HasComments: Yes
