Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12229 )
Change subject: IMPALA-7731: Add TxRatio counter to instances and query profile ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12229/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12229/1//COMMIT_MSG@16 PS1, Line 16: by instances with a scan over the data read by all scans of the Why do we only include the data transmitted from instances with scans? I think both are useful: one is a metric of "how much of our network traffic is driven by scans" and the one you've implemented is "how much filtering out are our scanners doing". Is that the right distinction? I think both are useful (and are decent proxies). In that vein, how would you feel about having total metrics in the profile, like "total number of bytes read from hdfs" and "total number of bytes exchanged"... -- To view, visit http://gerrit.cloudera.org:8080/12229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife7ec78fe42558429c1cbe6e5eba79842bffd648 Gerrit-Change-Number: 12229 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 17 Jan 2019 21:27:08 +0000 Gerrit-HasComments: Yes
