Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12229 )
Change subject: IMPALA-7731: Add TxRatio counter to instances and query profile ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/12229/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/12229/2/be/src/runtime/coordinator.cc@794 PS2, Line 794: nit: extra line http://gerrit.cloudera.org:8080/#/c/12229/2/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12229/2/tests/query_test/test_observability.py@391 PS2, Line 391: lineitem This query takes 3.4 secs on my machine, which is far from extreme, but I would prefer to choose a cheaper one if it is enough for the test. -- To view, visit http://gerrit.cloudera.org:8080/12229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife7ec78fe42558429c1cbe6e5eba79842bffd648 Gerrit-Change-Number: 12229 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Fri, 18 Jan 2019 16:52:35 +0000 Gerrit-HasComments: Yes
