Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12229 )
Change subject: IMPALA-7731: Add TxRatio counter to instances and query profile ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/12229/2/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/12229/2/be/src/runtime/coordinator-backend-state.cc@251 PS2, Line 251: if (instance_utilization.bytes_read > 0) { Is this how we determine whether the fragment had a scan in it or not? Possibly add a comment to this effect. http://gerrit.cloudera.org:8080/#/c/12229/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/12229/2/be/src/runtime/coordinator.cc@779 PS2, Line 779: COUNTER_SET(ADD_COUNTER(query_profile_, "TotalBytesSent", TUnit::BYTES), Should we add comments here about what these new counters mean? (Especially "Inner" seems ambiguous) -- To view, visit http://gerrit.cloudera.org:8080/12229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife7ec78fe42558429c1cbe6e5eba79842bffd648 Gerrit-Change-Number: 12229 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 17 Jan 2019 23:00:05 +0000 Gerrit-HasComments: Yes
