Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12229 )
Change subject: IMPALA-7731: Add Read/Exchange counters to profile ...................................................................... Patch Set 3: Code-Review+2 (4 comments) Thanks! http://gerrit.cloudera.org:8080/#/c/12229/3/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/12229/3/be/src/runtime/coordinator-backend-state.cc@524 PS3, Line 524: //if (!p->metadata().__isset.plan_node_id) continue; ?? http://gerrit.cloudera.org:8080/#/c/12229/3/be/src/runtime/coordinator-backend-state.cc@531 PS3, Line 531: RuntimeProfile::Counter* bytes_sent = p->GetCounter("TotalBytesSent"); This this be a constant somewhere? http://gerrit.cloudera.org:8080/#/c/12229/3/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/12229/3/be/src/runtime/coordinator.cc@790 PS3, Line 790: // node. Is it the case that TotalBytesSent == TotalScanBytesSent + TotalInnerBytesSent ? Do we have a place to DCHECK assert that and/or test it? http://gerrit.cloudera.org:8080/#/c/12229/3/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12229/3/tests/query_test/test_observability.py@390 PS3, Line 390: def test_exchange_scan_ratio_non_zero(self): Should we add small tests for the other new metrics you have? -- To view, visit http://gerrit.cloudera.org:8080/12229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife7ec78fe42558429c1cbe6e5eba79842bffd648 Gerrit-Change-Number: 12229 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Fri, 18 Jan 2019 22:40:15 +0000 Gerrit-HasComments: Yes
