Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12296 )
Change subject: IMPALA-8093: Prefix time series counters with a hyphen ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/12296/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12296/6//COMMIT_MSG@13 PS6, Line 13: Add TimeSeriesCounter prefix checks in test_observability tests. nit: trailing whitespace http://gerrit.cloudera.org:8080/#/c/12296/6//COMMIT_MSG@19 PS6, Line 19: … I'm not sure whether these ... in the commit message might cause issues for some tools since they're not ascii characters. To be on the safe side you could replace them with three single dots. http://gerrit.cloudera.org:8080/#/c/12296/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12296/6/tests/query_test/test_observability.py@404 PS6, Line 404: assert re.search(" MemoryUsage", profile) is None I don't think you need a regex here but you could just do "assert pattern in profile" like below -- To view, visit http://gerrit.cloudera.org:8080/12296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e3f08da765b3e6dedead45760729cbc5e8fb6fa Gerrit-Change-Number: 12296 Gerrit-PatchSet: 6 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Fri, 01 Feb 2019 19:27:00 +0000 Gerrit-HasComments: Yes
