Hello Bharath Vissapragada, Lars Volker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12296
to look at the new patch set (#7).
Change subject: IMPALA-8093: Prefix time series counters with a hyphen
......................................................................
IMPALA-8093: Prefix time series counters with a hyphen
The change makes profiles prefix counters consistent.
Only TimeSeriesCounters are affected.
Testing:
Add TimeSeriesCounter prefix checks in test_observability tests.
Manual Tests: Run query and check profile for MemoryUsage and
ThreadUsage. Following section of profile shows that TimeSeriesCounters
are consistent with other counters:
Fragment F00:
. . .
Fragment Instance Lifecycle Event Timeline: 273.841ms
- Prepare Finished: 1.511ms (1.511ms)
. . .
- MemoryUsage(500.000ms): 2.81 MB
- ThreadUsage(500.000ms): 1
- AverageThreadTokens: 1.00
- BloomFilterBytes: 1.00 MB (1048576)
- ExchangeScanRatio: 0.00
- PeakMemoryUsage: 54.26 MB (56891933)
- PeakReservation: 53.00 MB (55574528)
Change-Id: I2e3f08da765b3e6dedead45760729cbc5e8fb6fa
---
M be/src/util/runtime-profile.cc
M tests/query_test/test_observability.py
2 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/12296/7
--
To view, visit http://gerrit.cloudera.org:8080/12296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e3f08da765b3e6dedead45760729cbc5e8fb6fa
Gerrit-Change-Number: 12296
Gerrit-PatchSet: 7
Gerrit-Owner: Yongzhi Chen <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Yongzhi Chen <[email protected]>
