Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12296 )
Change subject: IMPALA-8093: Prefix time series counters with a hyphen ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/12296/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12296/6//COMMIT_MSG@13 PS6, Line 13: Add TimeSeriesCounter prefix checks in test_observability tests. > nit: trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/12296/6//COMMIT_MSG@19 PS6, Line 19: . . . > I'm not sure whether these ... in the commit message might cause issues for I used 3 single dots. To be safe, I will add space between them http://gerrit.cloudera.org:8080/#/c/12296/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12296/6/tests/query_test/test_observability.py@404 PS6, Line 404: assert " MemoryUsage" not in profile > I don't think you need a regex here but you could just do "assert pattern i Done -- To view, visit http://gerrit.cloudera.org:8080/12296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e3f08da765b3e6dedead45760729cbc5e8fb6fa Gerrit-Change-Number: 12296 Gerrit-PatchSet: 7 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Feb 2019 22:30:35 +0000 Gerrit-HasComments: Yes
