Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 )
Change subject: IMPALA-7927: Enhance Rewritten SQL in test files ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Lgtm. I'm not super comfortable with this piece of code. So I'd prefer to get an additional pair of eyes to +2 it, just to be sure that it doesn't break any existing semantics. Adding Thomas since he touched this in the context of multiple-count-distinct. http://gerrit.cloudera.org:8080/#/c/12033/2/fe/src/main/java/org/apache/impala/analysis/SlotRef.java File fe/src/main/java/org/apache/impala/analysis/SlotRef.java: http://gerrit.cloudera.org:8080/#/c/12033/2/fe/src/main/java/org/apache/impala/analysis/SlotRef.java@43 PS2, Line 43: private final String colLabel_; Add a quick comment on how this is different form label_? -- To view, visit http://gerrit.cloudera.org:8080/12033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09ee971a7797c4154bafee5c080ac3c6a1057fc7 Gerrit-Change-Number: 12033 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Thu, 07 Feb 2019 19:31:28 +0000 Gerrit-HasComments: Yes
