Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 )
Change subject: IMPALA-7927: Enhance Rewritten SQL in test files ...................................................................... Patch Set 2: Good points. Let me rethink this. The reason for the current approach is that the expression can be arbitrarily long: foo + bar /* a0$1 */ -- does the reference apply to "bar" or "foo + bar"? Since this is all pretty obscure, let me find a different way to solve this. -- To view, visit http://gerrit.cloudera.org:8080/12033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09ee971a7797c4154bafee5c080ac3c6a1057fc7 Gerrit-Change-Number: 12033 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Tue, 12 Feb 2019 01:06:03 +0000 Gerrit-HasComments: No
