Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 )
Change subject: IMPALA-7927: Enhance Rewritten SQL in test files ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12033/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12033/2//COMMIT_MSG@7 PS2, Line 7: in test files > This patch also has a user-facing impact on EXPLAIN output at explain_level Good point. How about we place the slot label in inline comments. Something like HAVING sum(2 +id) /* $ao$1 */ > CAST(...) ? -- To view, visit http://gerrit.cloudera.org:8080/12033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09ee971a7797c4154bafee5c080ac3c6a1057fc7 Gerrit-Change-Number: 12033 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Mon, 11 Feb 2019 23:27:26 +0000 Gerrit-HasComments: Yes
