Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 )
Change subject: IMPALA-8163: Add banner showing for local catalog mode when enabled. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12413/1/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/12413/1/be/src/util/default-path-handlers.cc@254 PS1, Line 254: Value use_local_catalog(FLAGS_use_local_catalog); Move this below is_coordinator check? http://gerrit.cloudera.org:8080/#/c/12413/1/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12413/1/tests/custom_cluster/test_web_pages.py@47 PS1, Line 47: def test_observability(self): Last we discussed, I thought we wanted to add this in test_local_catalog.py. Rename test_cache_metrics to test_observability and include this there? Any reason for not doing it? http://gerrit.cloudera.org:8080/#/c/12413/1/www/root.tmpl File www/root.tmpl: http://gerrit.cloudera.org:8080/#/c/12413/1/www/root.tmpl@30 PS1, Line 30: (V2) Thinking about this again, probably omit this, since that does not make sense from a user POV. -- To view, visit http://gerrit.cloudera.org:8080/12413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb2c7b20742a2630d9509da9b629d5f45c55207 Gerrit-Change-Number: 12413 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 08 Feb 2019 20:46:03 +0000 Gerrit-HasComments: Yes
