Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 )
Change subject: IMPALA-8163: Add banner showing for local catalog mode when enabled. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12413/1/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12413/1/tests/custom_cluster/test_web_pages.py@47 PS1, Line 47: def test_observability(self): > Last we discussed, I thought we wanted to add this in test_local_catalog.py test_cache_metrics is confined in TestCompactCatalogUpdates which did not seem like a place for observability tests. Also, test_web_pages.py already does something close to observability test. Is there a performance implication for doing it this way? http://gerrit.cloudera.org:8080/#/c/12413/1/www/root.tmpl File www/root.tmpl: http://gerrit.cloudera.org:8080/#/c/12413/1/www/root.tmpl@30 PS1, Line 30: (V2) > Thinking about this again, probably omit this, since that does not make sen Okay, omitting V2. -- To view, visit http://gerrit.cloudera.org:8080/12413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb2c7b20742a2630d9509da9b629d5f45c55207 Gerrit-Change-Number: 12413 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Feb 2019 21:03:11 +0000 Gerrit-HasComments: Yes
