Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 )
Change subject: IMPALA-8163: Add banner showing for local catalog mode when enabled. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12413/1/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12413/1/tests/custom_cluster/test_web_pages.py@47 PS1, Line 47: def test_observability(self): > test_cache_metrics is confined in TestCompactCatalogUpdates which did not s Looking at it again, I don't think test_cache_metrics has anything to do with CompactCatalogUpdates. How about we move it out to a separate class TestObservability? -- To view, visit http://gerrit.cloudera.org:8080/12413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb2c7b20742a2630d9509da9b629d5f45c55207 Gerrit-Change-Number: 12413 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 08 Feb 2019 23:02:06 +0000 Gerrit-HasComments: Yes
